Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes paths comprehension in api plugin #796

Merged
merged 2 commits into from
Mar 16, 2018
Merged

fixes paths comprehension in api plugin #796

merged 2 commits into from
Mar 16, 2018

Conversation

gitoleg
Copy link
Contributor

@gitoleg gitoleg commented Mar 16, 2018

fix #776

So everybody is welcome to set api path like $ bap bin/exe --api-path=.

@ivg
Copy link
Member

ivg commented Mar 16, 2018

will bap bin/exe --api-path=./hello work with this fix?

@gitoleg
Copy link
Contributor Author

gitoleg commented Mar 16, 2018

I would say that your example will work even without this fix, i.e. it worked before.

@ivg
Copy link
Member

ivg commented Mar 16, 2018

Good, that's what I was expecting. Thanks

@ivg ivg merged commit 00a2461 into BinaryAnalysisPlatform:master Mar 16, 2018
@gitoleg gitoleg deleted the fix-api-pwd branch March 16, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivg ivg ivg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the --api-path parameter doesn't understand dots (.)
2 participants
@gitoleg @ivg