-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation #429
Merged
Merged
Fix compilation #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et. Few features disabled, still needs work
make empty destructors default, same effect. do we even need to define them? Fix uses platform dependent header files defining what gets passed to the different update functions All "fix me"s eradicated needs testing to ensure nothing broke
switch: - make InputState hold the data directly instead of inheriting the 2 used things. - make it hold 3 u64 attributes for the keys, instead of exposing PadState and requiring usage to be through padGetButtons and derivatives - added a global constant pointer to it for Clickable and Scrollable to use, hoping to fix the crash
M:/GitHub/Checkpoint/switch/source/configuration.cpp: In function 'void handle_populate(mg_connection*, http_message*)': M:/GitHub/Checkpoint/switch/source/configuration.cpp:34:76: warning: unused parameter 'hm' [-Wunused-parameter] 34 | static void handle_populate(struct mg_connection* nc, struct http_message* hm) | ~~~~~~~~~~~~~~~~~~~~~^~
Scrollable was crashing because we were dereferencing `input` when it could be `nullptr`. To make the code more fault tolerant, I added checks to make sure `input` is valid before dereferencing. But the more important change is to propagate `g_input` by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.