Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation #429

Merged
merged 13 commits into from
Nov 11, 2021
Merged

Fix compilation #429

merged 13 commits into from
Nov 11, 2021

Conversation

FM1337
Copy link
Contributor

@FM1337 FM1337 commented Nov 11, 2021

No description provided.

BernardoGiordano and others added 13 commits April 13, 2021 09:50
make empty destructors default, same effect. do we even need to define them?
Fix uses platform dependent header files defining what gets passed to the different update functions
All "fix me"s eradicated
needs testing to ensure nothing broke
switch:
- make InputState hold the data directly instead of inheriting the 2 used things.
- make it hold 3 u64 attributes for the keys, instead of exposing PadState and requiring usage to be through padGetButtons and derivatives
- added a global constant pointer to it for Clickable and Scrollable to use, hoping to fix the crash
M:/GitHub/Checkpoint/switch/source/configuration.cpp: In function 'void handle_populate(mg_connection*, http_message*)':
M:/GitHub/Checkpoint/switch/source/configuration.cpp:34:76: warning: unused parameter 'hm' [-Wunused-parameter]
   34 | static void handle_populate(struct mg_connection* nc, struct http_message* hm)
      |                                                       ~~~~~~~~~~~~~~~~~~~~~^~
Scrollable was crashing because we were dereferencing `input` when it could be `nullptr`. To make the code more fault tolerant, I added checks to make sure `input` is valid before dereferencing.

But the more important change is to propagate `g_input` by default.
@FM1337 FM1337 merged commit dd98dde into master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants