Fix scrollable by propagating g_input by default.
#427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrollable was crashing because we were dereferencing `input` when it could be `nullptr`. To make the code more fault tolerant, I added checks to make sure `input` is valid before dereferencing. But the more important change is to propagate `g_input` by default.
|
I tested with joycons and with tapping the touchscreen, and the scrollable list works. I backed up some saves and such too. Everything seemed to be working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrollable was crashing because we were dereferencing
inputwhen it could benullptr. To make the code more fault tolerant, I added checks to make sureinputis valid before dereferencing.But the more important change is to propagate
g_inputby default.This gets the app into a fully functional state.