Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GL_INVALID_ENUM error reason in es3/glFramebufferTexture2D #139

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

jsyishan
Copy link
Contributor

there is a mistake in es3/glFramebufferTexture2D, referenced from https://registry.khronos.org/OpenGL-Refpages/es3/html/glFramebufferTexture2D.xhtml

@BSVino
Copy link
Owner

BSVino commented Aug 30, 2023

Which error is reported depends on which driver you're using and could change from driver to driver. One error could be emitted for many different reasons. The reason for error that you deleted is still a valid one I would think. I suggest you keep that one instead of deleting it, and show both reasons.

@jsyishan
Copy link
Contributor Author

Which error is reported depends on which driver you're using and could change from driver to driver. One error could be emitted for many different reasons. The reason for error that you deleted is still a valid one I would think. I suggest you keep that one instead of deleting it, and show both reasons.

the original one is GL_INVALID_ENUM is generated if renderbuffertarget is not GL_RENDERBUFFER., which renderbuffertarget is none of the parameters from glFramebufferTexture2D, maybe it was just a typo or something? lol

@BSVino BSVino merged commit 080c215 into BSVino:mainline Aug 31, 2023
@BSVino
Copy link
Owner

BSVino commented Aug 31, 2023

Ah gotcha. Looks good then! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants