Navigate to search result on selection from the autocomplete dropdown #123
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids needing to click on "Go" every time after you select the suggestion that you want. The "Go" button still works as expected if you don't interact with the autocomplete at all.
|
Nice one! I never was able to figure this one out. |
|
By the way exceptional work with the gifs I've never seen a better PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids needing to click on "Go" every time after you select the suggestion that you want, which I think is a significant quality-of-life improvement. The "Go" button still works as expected if you don't interact with the autocomplete at all.
Previously it looked like this:
Now it looks like this:
It looks like this may have been the original intention and just wasn't working. The function to navigate to the search result was already being called when the user selects an autocomplete option, it was just passing in the text that the user had typed, rather than the text of the selected autocomplete option.