Fix compile process for python3 on Windows #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it stands python3 will fail to read in the input xhtml files because they contain bytes that are not valid using the default codepage on Windows (in English at least). Loading those files as utf-8 explicitly resolves this issue and is correct as long as all the xhtml files are utf-8 encoded.
|
Odd because the build action uses python 3. Maybe it's just a Windows thing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear whether python3 is supported. I would expect so considering that (as far as I know, I'm not usually a python developer) python2 is deprecated. The readme does not specify and the build.bat windows script explicitly calls out Python27 in the path.
As it stands python3 will fail to read in the input xhtml files because they contain bytes that are not valid using the default codepage on Windows (in English at least). Loading those files as utf-8 explicitly resolves this issue and is correct as long as all the xhtml files are utf-8 encoded. I have no idea what the encoding for those xhtml pages is intended to be but utf-8 seems like generally a reasonable assumption and it seems to work on the few pages I checked.