Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in cross product formula (GLSL ES3) #118

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix typo in cross product formula (GLSL ES3) #118

merged 1 commit into from
Mar 17, 2022
+1 −1

Conversation

andystanton
Copy link
Contributor

As per #117

The last row of the cross product formula is given as:

𝑥[0]⋅𝑦[1]−𝑦[1]⋅𝑥[1]

It should be:

𝑥[0]⋅𝑦[1]−𝑦[0]⋅𝑥[1]

This PR makes this change.

@andystanton
Fix typo in cross product formula (GLSL ES3)
3f7ed77 
The last row of the cross product formula is given as:
> 𝑥[0]⋅𝑦[1]−𝑦[1]⋅𝑥[1]

It should be:
> 𝑥[0]⋅𝑦[1]−𝑦[0]⋅𝑥[1]

This PR makes this change.
@andystanton andystanton mentioned this pull request Mar 17, 2022
Merged
@BSVino BSVino merged commit 836ec3c into BSVino:mainline Mar 17, 2022
@BSVino
Copy link
Owner

BSVino commented Mar 17, 2022

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andystanton @BSVino