Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue temporary ban by network id instead of user id #82

Merged
merged 1 commit into from
Jul 23, 2016

Conversation

TomyLobo
Copy link
Collaborator

This will prevent cheaters from dodging votekicks.

@BSVino
Copy link
Owner

BSVino commented Jul 23, 2016

What is the network id? IP? I'm hesitant to ban people by IP because of lans and recycled IPs n shit.

@BSVino
Copy link
Owner

BSVino commented Jul 23, 2016

Oh is it the Steam ID? Yea, ship that shit.

@TomyLobo TomyLobo merged commit 61df938 into develop Jul 23, 2016
@TomyLobo TomyLobo deleted the votekick-fix branch July 23, 2016 07:23
@TomyLobo TomyLobo added this to the v1.2.2 milestone Jul 23, 2016
@TomyLobo
Copy link
Collaborator Author

That's indeed the Steam ID.
Btw, why not ban people by IP for half an hour, in addition to the ID ban?
In the case of internet servers, the chance of someone getting votekicked, changing their IP, someone else picking up that IP and trying to play Double Action on the exact same server are miniscule.
And in the case of LAN servers, tempbanning by IP is exactly what you want.

TomyLobo added a commit that referenced this pull request Apr 6, 2018
That error was copied from the english version, where it was fixed in #82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants