Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sliding through certain glass panes #45

Merged
merged 1 commit into from
Apr 2, 2016
Merged

Fix sliding through certain glass panes #45

merged 1 commit into from
Apr 2, 2016

Conversation

TomyLobo
Copy link
Collaborator

@TomyLobo TomyLobo commented Apr 2, 2016

  • da_trainingday: every single glass pane under those railings
  • da_cocaine: both bathroom windows

If I further lift the lower bounds from -15 to -14, this hole on da_morgendorffer no longer opened by simply sliding over it:
hole on da_morgendorffer
Do we want that?

@BSVino
Copy link
Owner

BSVino commented Apr 2, 2016

Ship it.

@TomyLobo
Copy link
Collaborator Author

TomyLobo commented Apr 2, 2016

Ship what? :)
The code as it is (which would only fix sliding through glass)
or with the lower bounds raised to -14 (which would also fix sliding through the hole on da_morgendorffer)

@BSVino
Copy link
Owner

BSVino commented Apr 2, 2016

Was referring to your patch, "Fix sliding through certain ..."

- da_trainingday: every single glass pane under those railings
- da_cocaine: both bathroom windows
@TomyLobo TomyLobo merged commit f68bd46 into BSVino:develop Apr 2, 2016
@TomyLobo TomyLobo deleted the fix-sliding-through-glass branch April 2, 2016 14:45
@TomyLobo TomyLobo added this to the v1.2.1 milestone Apr 3, 2016
TomyLobo added a commit that referenced this pull request Apr 20, 2016
Fix sliding through certain glass panes
shmopaloppa pushed a commit to shmopaloppa/DoubleAction that referenced this pull request Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants