Fix auto-unstick feature #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomyLobo
force-pushed
the
develop
branch
2 times, most recently
from
5e4152f to
ba8390e
Compare
|
I've been burned by putting stuff in GameMovement before. I keep forgetting that there's only one for all players. Maybe put a comment in there to prevent the same error in the future? Ship it. |
|
Like so? :) |
CDAGameMovement appears to have a single global instance. This causes the da_auto_unstick feature to break with any player number greater than 1, because there usually is at least one player that is not stuck.
|
Cool. Ship it. |
shmopaloppa
pushed a commit
to shmopaloppa/DoubleAction
that referenced
this pull request
Sep 13, 2017
Fix da_auto_unstick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source contains a feature (da_auto_unstick) which actually works quite well in unsticking players, as long as there is only one player on the server.
As soon as another player (or a bot) is on the player, it breaks.
This happens because certain state is stored in what appears to be a global variable.
My fix moves that to the individual CDAPlayer instances.
Same changes as #29 but retargeted to the
developbranch.