Fix being stuck when dive-rolling in a place that only has enough room to go prone #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomyLobo
force-pushed
the
develop
branch
2 times, most recently
from
5e4152f to
ba8390e
Compare
|
I can't say either whether removing the return will cause any problems. Have you looked in the annotations for its history? |
|
This has been taken from CGameMovement::PlayerMove, i.e. it's probably from the original sdk. |
|
It's probably fine then. Ship it. |
TomyLobo
added a commit
that referenced
this pull request
Apr 20, 2016
Fix being stuck when dive-rolling in a place that only has enough room to go prone
shmopaloppa
pushed a commit
to shmopaloppa/DoubleAction
that referenced
this pull request
Sep 13, 2017
Fix being stuck when dive-rolling in a place that only has enough room to go prone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a few instances of being stuck after a dive-roll by setting the player to prone when that situation is encountered.
I'm not quite sure if that's the correct way to switch from roll to prone. It appears to work, though.
I'm also not entirely sure if removing that "return" in
CDAGameMovement::RealPlayerMovehas any side effects, but I noticed none.Removing it was a requirement for
CDAGameMovement::Duck, and thus the mitigation code, to run in all instances of stuckness (that I've been able to reproduce).Same changes as #30 but retargeted to the
developbranch.