Fix another infinite climb bug #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unwraps most of the code from the if body
This again unwraps most of the code from the if body
Since CheckMantel returned true, m_pSDKPlayer->m_Shared.IsManteling() can't possibly be false here. CheckMantel() returns true under one of two conditions: 1. m_pSDKPlayer->m_Shared.IsManteling() is true 2. m_pSDKPlayer->m_Shared.StartManteling has just been called, which sets the member variable returned by m_pSDKPlayer->m_Shared.IsManteling() to true So since this is useless and confusing, I'm removing it.
…ne which wall to climb
BSVino
approved these changes
Nov 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to the other climb bug, there are a ton more spots for this to exploit and it's also way easier to exploit.
I'm not going to try and count them :)
This introduces a tiny variance in the allowable angle between you and the wall.
That variance might have been wall-dependent before, now it's fixed to a dot product of 0.05, which is about 87.13° to the normal or 3° to the plane.
Shouldn't be noticable, since the most extreme place I tried had an allowable angle of about 88° to the normal under the old behaviour.
Thanks to Johnny shoe oswald man birb for reporting this.