Yes, that was intended.
I think the new behaviour is better, since it doesn't force you to go through a bunch of dropped guns on the floor while you're being shot at, in order to find the gun you just accidentally autodropped :)

If someone desparately wants the old behaviour, they can use the cvar.
If someone just sometimes wants to grab a gun from the ground while they're full, they can easily drop one of their guns.

But like I said, I'm open to debate about the default value for the cvar :)

Rebased

I don't think you're wrong but I prefer not to change the behavior, as there are now a lot of user expectations associated with the current behavior.

Not that I think the way it is now is necessarily the best way to go, but I made it that way because I was worried that people might not know why they can't pick up a weapon from the ground. IE they press e but nothing happens, and they don't understand that they have to drop something. So I drop something automatically if you're full because the player can always pick it up again, and I know that the player most likely wants the weapon on the ground more. I don't remember whether this was an issue that actually came up in playtesting or whether I was going by hunch.

In an ideal world I'd like to see a solution that involved better indicators to show that either you can't pick up a gun unless you drop things or that you're going to drop something if you pick something up, and I'd probably lean towards the latter.

Hmm, I can pop up a notice on how to drop weapons if you hit the limit.
Would that address your concerns?

Rebased again

I'd have to see a design.

How's this? :)

It's slowly flashing to a yellowish color.
Should look similar to the tutorial/lesson/instructor stuff

Include in that same panel the key to drop, e.g. "Inventory Full \n [G] Drop Weapon" and I think I'm OK with that.

Gotta figure out how that works, first :)

Turns out you can just use "%drop%" in a hint message and the client will replace it accordingly:

I also rebased it all.