-
Notifications
You must be signed in to change notification settings - Fork 28
Comparing changes
Open a pull request
base repository: Azure/go-ansiterm
base: d6e3b33
head repository: Azure/go-ansiterm
compare: d185dfc
- 9 commits
- 5 files changed
- 5 contributors
Commits on Jun 5, 2021
-
Added compatibility with "golang.org/x/sys/windows"
Many of the consumers of this library use "golang.org/x/sys/windows" since it's better maintained then syscall package. This has caused breaking changes with several clients this PR fixes these migration issues + maintain compatibility with the consumers of syscall package
Configuration menu - View commit details
-
Copy full SHA for 3ee0038 - Browse repository at this point
Copy the full SHA 3ee0038View commit details
Commits on Jun 8, 2021
-
Merge pull request #31 from n4j/syscallFix
Added compatibility with "golang.org/x/sys/windows"
Configuration menu - View commit details
-
Copy full SHA for 43c61cb - Browse repository at this point
Copy the full SHA 43c61cbView commit details -
winterm: fix GetStdFile() falltrough
Commit 3ee0038 updated the switch with the intent to handle either syscall.XX or golang.org/x/sys/win.XX values. However, Go "switch" does not have an implicit "fallthrough" behavior, and either requires the "fallthrough" keyword to be used, or to combine values in a single "case". For example, the following: for _, v := range []int{1, 2, 3, 4, 5, 6, 7} { result := "unknown" switch v { case 1: // doesn't fall-through, so this is an empty "case" case 2: result = "found one or two" case 3: fallthrough // falls through to "case 4" case 4: result = "found three or four" case 5, 6: // matches either 5 or 6 result = "found five or six" default: result = "found something else" } fmt.Printf("%d: %s\n", v, result) } Will print: 1: unknown 2: found one or two 3: found three or four 4: found three or four 5: found five or six 6: found five or six 7: found something else This patch combines "equal" values in a single case within the switch to fix this issue. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for ca5fe9f - Browse repository at this point
Copy the full SHA ca5fe9fView commit details -
Merge pull request #32 from thaJeztah/fix_switch
winterm: fix GetStdFile() falltrough
Configuration menu - View commit details
-
Copy full SHA for 2377c96 - Browse repository at this point
Copy the full SHA 2377c96View commit details
Commits on Jun 17, 2021
-
Convert int to string using rune()
See golang/go#32479 Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 65725d2 - Browse repository at this point
Copy the full SHA 65725d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a041bb6 - Browse repository at this point
Copy the full SHA a041bb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7db606f - Browse repository at this point
Copy the full SHA 7db606fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a086cd - Browse repository at this point
Copy the full SHA 5a086cdView commit details -
Merge pull request #33 from cpuguy83/fix_int_overflow
Fix int overflow
Configuration menu - View commit details
-
Copy full SHA for d185dfc - Browse repository at this point
Copy the full SHA d185dfcView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d6e3b33...d185dfc