Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#312 Iterate through dependsOn when creating extraProperties dictionary in Generator code #320

Merged
merged 18 commits into from
Apr 11, 2023
Merged

#312 Iterate through dependsOn when creating extraProperties dictionary in Generator code #320

merged 18 commits into from
Apr 11, 2023

Conversation

marclerwick
Copy link
Member

@marclerwick marclerwick commented Apr 11, 2023 •
edited
Loading

Updated the GetExtraProperties method to iterate over the array of DependsOn to extract all keys and values.

Closes #312

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 8 0 0.05s
✅ BICEP bicep_linter 23 0 61.99s
✅ COPYPASTE jscpd yes no 3.91s
✅ CSHARP csharpier 53 0 3.22s
✅ EDITORCONFIG editorconfig-checker 295 0 0.58s
✅ JSON eslint-plugin-jsonc 8 0 0.81s
✅ JSON jsonlint 5 0 0.14s
✅ JSON prettier 8 0 0.49s
✅ JSON v8r 8 0 3.78s
✅ MARKDOWN markdownlint 36 0 0.49s
✅ MARKDOWN markdown-link-check 35 0 8.23s
✅ MARKDOWN markdown-table-formatter 36 0 0.23s
✅ POWERSHELL powershell 153 0 287.4s
✅ POWERSHELL powershell_formatter 154 0 182.3s
✅ REPOSITORY gitleaks yes no 0.31s
✅ REPOSITORY secretlint yes no 1.34s
✅ SPELL misspell 295 0 0.1s
✅ XML xmllint 1 0 0.0s
✅ YAML prettier 11 0 0.71s
✅ YAML v8r 11 0 6.17s
✅ YAML yamllint 11 0 0.3s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@marclerwick @ozboms
Update BenchPress/Generators/AzureDeploymentImporter.cs
6e069bf 
Co-authored-by: Ozi Boms <zboms123@gmail.com>
@ozboms
Copy link
Contributor

ozboms commented Apr 11, 2023 •
edited
Loading

LGTM if tested and works. Just some clarification with code comments. Feel free to go with suggestions or update your own way.

marclerwick and others added 4 commits April 11, 2023 14:07
@marclerwick marclerwick merged commit 9522aff into main Apr 11, 2023
@marclerwick marclerwick deleted the feature/312 branch April 11, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozboms ozboms ozboms approved these changes

@msha1026 msha1026 msha1026 approved these changes

@polatengin polatengin Awaiting requested review from polatengin

@hattan hattan Awaiting requested review from hattan

@jasonshortphd jasonshortphd Awaiting requested review from jasonshortphd

@quigg-caroline quigg-caroline Awaiting requested review from quigg-caroline

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterate through dependsOn when creating extraProperties dictionary in Generator code
3 participants
@marclerwick @ozboms @msha1026