Upload dependency graph and add badge #9799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
scbedd
approved these changes
Feb 14, 2020
weshaggard
reviewed
Feb 19, 2020
| @@ -59,12 +59,14 @@ steps: | |||
|
|
|||
| - task: PythonScript@0 | |||
| displayName: 'Verify sdist' | |||
| condition: ne(variables['Skip.VerifySdist'],'true') | |||
There was a problem hiding this comment.
These conditions need to have the succeeded() added to them.
weshaggard
reviewed
Feb 19, 2020
| vmImage: 'windows-2019' | ||
|
|
||
| steps: | ||
| - template: ../steps/analyze.yml |
There was a problem hiding this comment.
Doesn't this cause all the analyze steps to happen both here and in every pipeline? shouldn't there be some filtering of some sort?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload dependency report to artifact blob location and add badge to refer this graph from github repo