Improve chained and defaultazurecredential error messages #8109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with slightly more detail, and spacing.
|
Can one of the admins verify this patch? |
chlowell
reviewed
Oct 22, 2019
sdk/identity/azure-identity/azure/identity/_credentials/default.py
Outdated
Show resolved
Hide resolved
chlowell
approved these changes
Oct 23, 2019
sdk/identity/azure-identity/azure/identity/_credentials/chained.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/azure/identity/_credentials/default.py
Outdated
Show resolved
Hide resolved
schaabs
reviewed
Oct 24, 2019
KieranBrantnerMagee
added
Azure.Identity
Client
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 11, 2019
…into increasing_policy_test_coverage * 'master' of https://github.com/Azure/azure-sdk-for-python: move remaining smoketest files out of samples folder (this branch was open a long time ago and the new files were missed in a rebase) [Storage] Improve Bad Connection String message (Azure#8471) set read only change (Azure#8453) fix NetworkTraceLoggingPolicy to save logging_enable in context (Azure#8469) Improve chained and defaultazurecredential error messages (Azure#8109) [AutoPR] cosmos-db/resource-manager (Azure#8009)
xiangyan99
added a commit
that referenced
this pull request
Nov 12, 2019
* [AutoPR] cosmos-db/resource-manager (#8009) * [AutoPR cosmos-db/resource-manager] Add Sql StoredProcedures, UDFs and Triggers for CosmosDB resources (#7369) * Generated from 5e92b1905562d8700a822323582227df1a50540e introducing Sql StoreProcedures in CosmosDB Resources * Generated from 475ed8ecb444f16acaf7c387a491fb459a8af08b additional changes * Generated from 44e321cfac5b8d3d211e0826b44696674a78a7b4 addressed comments from ARM * Generated from 59fba539e99c62e2ed249308bab54f01d4dec32d modeling triggerType as enum * Generated from 1b3dc2af41354e999b07358a3e57394e1ec98524 typo * Generated from c4257daedeab6595725589c25bd2ab3568583f79 fix for model validation check * Generated from 85b2cb4e0a6eb554fd1cb274d8a6dbdf3ce13055 (#7679) chore: jsonfmt cosmos-db * regenerated * fix script * another place * fix * fix * one more change * one more * regenerated * history and version * regenerated tests * regenerated cosmosdb single api * update * regenerated again * updated history + fixes * rerecorded tests * Improve chained and defaultazurecredential error messages (#8109) * Attempt to bolster chained and defaultazurecredential error messages with slightly more detail, and spacing. * Add aka link to identity docs for defaultazurecredential exceptions * Fix lint failures, further nitpicks to capitalization, spacing, and verbage. * PR comments, tweaking error verbage and pylint modifiers. * fix NetworkTraceLoggingPolicy to save logging_enable in context (#8469) * fix NetworkTraceLoggingPolicy to save logging_enable in context * add tests * set read only change (#8453) * set read only change * make pylint happy * add PR # * delete unwanted tests * fix typo * [Storage] Improve Bad Connection String message (#8471) * Improve Connection String message * change * add tests * changes * changes * move remaining smoketest files out of samples folder (this branch was open a long time ago and the new files were missed in a rebase) add remaining KV smoke tests back in add to requirements allow for other versions of python 3.7 update to use older interfaces fix up smoke tests for september 2019 preview name the matrix entry properly do not wait for cert creation in b3 * [AutoPR] azure-kusto/resource-manager (#7300) * Generated from 8264dcc49e0bc239013cd76ce9664f83f1041967 (#7036) Update Kusto.json with TSVE data format * Generated from 1998560b95ad1853979c663b19710407a2266926 (#7299) Updated readme files * Generated from 63d0bd0751dd12efb7a19fd63807a26919c02b11 (#7424) Add support for attached databases * regenerated kusto * changelist and version * removed files that were generated by mistake * Restapi auto eventgrid/resource manager (#8570) * regenerated eventgrid * history and version * changed version to rc2 * Update root readme with November releases (#8462) * Update root readme with Novemeber releases * Update README.md * Update README.md * Make preparer force https for storage account (#8563) * Update storage_testcase.py * small fix * Get Package namespace by parsing setup.py (#8461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds slightly more detail, spacing.
Closes #8041