Ensure we reset mocked methods on failure #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
bryevdv
added a commit
that referenced
this pull request
Jul 5, 2019
* Move code from azure-cosmos-python * upate for monorepo * attempt direct emulator download/install * split get/read database method (#5517) * split get/read database method * first stab at updating for Container * updates for get_user * get_item -> read_item * skip failing unicode test * additional renamings * add response_hook to Cosmos methods (#5557) * split get/read database method * first stab at updating for Container * add response_hook to CosmosClient methods * add response_hook to Container methods * add response_hook to Database methods * more response hooks * add RecordHeaders diagnostic * switch to a fixed set of common headers * use case insensitive dict * fix too-restrictive test * avoid mention of explicit headers * refine __all__ * response hook history for iteration (#5765) * response hook history for iteration * call response_hook with response body * POC aggregating request_charge * Bryanv/cosmos api followup (#6134) * rename get_database -> get_database_client * rename get_container -> get_container_client * rename get_user -> get_user_client * fixup diagnostic test * Packaging update of azure-cosmos * Revert "Packaging update of azure-cosmos" This reverts commit bc68c28. * revert pacakging bot for now * Cosmos DB v3 packaging (#6230) * Cosmos DB v3 packaging * Missing changelog * Universal wheel * run emulator tests on master * Cosmos v3 test updates (#6236) * Disable spatial index tests * Fix client constructor calls * remove retry test from emulator group * Cosmos v3 test updates (#6237) * Fix routing_map_tests * Ensure we reset mocked methods on failure (#6238) * Update version number + re-add cosmosEmulator marker for tests (#6243) * Update version number to beta instead of alpha * Re-add cosmosEmulator marker to retry tests * Update version number in changelog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the mocked out method "leaked" on failure and caused cleanup of tests and/or subsequent tests to fail.
Also changed the previous counter method that was using a test class global and instead provide a callable instance that keeps track of how many times it has been called.
This is one instance of a test that should be cleaned up further.