Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bryanv/cosmos api followup #6134

Merged
merged 4 commits into from
Jun 27, 2019
Merged

Bryanv/cosmos api followup #6134

merged 4 commits into from
Jun 27, 2019

Conversation

bryevdv
Copy link
Contributor

@bryevdv bryevdv commented Jun 27, 2019

This PR makes the following renames:

  • get_database -> get_database_client
  • get_container -> get_container_client
  • get_user -> get_user_client

As discussed after the UX study results.

Additionally, an issue with the diagnostic test is fixed (change was dropped somewhere, somehow)

@bryevdv bryevdv requested a review from lmazuel as a code owner June 27, 2019 17:41
@adxsdk6
Copy link

adxsdk6 commented Jun 27, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #6134 into cosmos_v3 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           cosmos_v3    #6134   +/-   ##
==========================================
  Coverage      48.07%   48.07%           
==========================================
  Files           6566     6566           
  Lines         189049   189049           
==========================================
  Hits           90882    90882           
  Misses         98167    98167
Impacted Files Coverage Δ
.../cosmos/azure-cosmos/azure/cosmos/cosmos_client.py 18.36% <100%> (ø) ⬆️
sdk/cosmos/azure-cosmos/azure/cosmos/database.py 14.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac65d9...1af757b. Read the comment docs.

@bryevdv bryevdv merged commit 54d178f into Azure:cosmos_v3 Jun 27, 2019
@bryevdv bryevdv deleted the bryanv/cosmos_api_followup branch June 27, 2019 21:00
bryevdv added a commit that referenced this pull request Jul 5, 2019
* Move code from azure-cosmos-python

* upate for monorepo

* attempt direct emulator download/install

* split get/read database method (#5517)

* split get/read database method

* first stab at updating for Container

* updates for get_user

* get_item -> read_item

* skip failing unicode test

* additional renamings

* add response_hook to Cosmos methods (#5557)

* split get/read database method

* first stab at updating for Container

* add response_hook to CosmosClient methods

* add response_hook to Container methods

* add response_hook to Database methods

* more response hooks

* add RecordHeaders diagnostic

* switch to a fixed set of common headers

* use case insensitive dict

* fix too-restrictive test

* avoid mention of explicit headers

* refine __all__

* response hook history for iteration (#5765)

* response hook history for iteration

* call response_hook with response body

* POC aggregating request_charge

* Bryanv/cosmos api followup (#6134)

* rename get_database -> get_database_client

* rename get_container -> get_container_client

* rename get_user -> get_user_client

* fixup diagnostic test

* Packaging update of azure-cosmos

* Revert "Packaging update of azure-cosmos"

This reverts commit bc68c28.

* revert pacakging bot for now

* Cosmos DB v3 packaging (#6230)

* Cosmos DB v3 packaging

* Missing changelog

* Universal wheel

* run emulator tests on master

* Cosmos v3 test updates (#6236)

* Disable spatial index tests

* Fix client constructor calls

* remove retry test from emulator group

* Cosmos v3 test updates (#6237)

* Fix routing_map_tests

* Ensure we reset mocked methods on failure (#6238)

* Update version number + re-add cosmosEmulator marker for tests (#6243)

* Update version number to beta instead of alpha

* Re-add cosmosEmulator marker to retry tests

* Update version number in changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants