Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Scripts - Repo Restructure #5115

Merged
merged 2 commits into from
May 8, 2019
Merged

Updating Scripts - Repo Restructure #5115

merged 2 commits into from
May 8, 2019

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented May 6, 2019

This PR updates the relevant management automation scripts as requested by @lmazuel.

@scbedd scbedd requested a review from lmazuel as a code owner May 6, 2019 22:38
@adxsdk6
Copy link

adxsdk6 commented May 6, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented May 7, 2019 •
edited
Loading

Codecov Report

Merging #5115 into master will decrease coverage by 3.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5115      +/-   ##
==========================================
- Coverage   52.99%      49%   -3.99%     
==========================================
  Files       10849     6508    -4341     
  Lines      227609   182526   -45083     
==========================================
- Hits       120613    89453   -31160     
+ Misses     106996    93073   -13923
Impacted Files Coverage Δ
...afactory/azure/mgmt/datafactory/models/__init__.py 50.67% <0%> (-49.33%) ⬇️
...ights/azure/applicationinsights/models/__init__.py 51% <0%> (-49%) ⬇️
...e/cognitiveservices/vision/face/models/__init__.py 51.08% <0%> (-48.92%) ⬇️
...services/language/textanalytics/models/__init__.py 51.16% <0%> (-48.84%) ⬇️
...iveservices/search/entitysearch/models/__init__.py 51.25% <0%> (-48.75%) ⬇️
azure-eventgrid/azure/eventgrid/models/__init__.py 51.25% <0%> (-48.75%) ⬇️
...ration/azure/mgmt/datamigration/models/__init__.py 51.27% <0%> (-48.73%) ⬇️
...ure/mgmt/recoveryservicesbackup/models/__init__.py 51.46% <0%> (-48.54%) ⬇️
...ce/azure/mgmt/containerinstance/models/__init__.py 51.8% <0%> (-48.2%) ⬇️
...tiveservices/search/videosearch/models/__init__.py 52.08% <0%> (-47.92%) ⬇️
... and 4427 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7181cb5...15a40f6. Read the comment docs.

@scbedd
Copy link
Member Author

scbedd commented May 8, 2019

@lmazuel The scripts work against azure-mgmt-compute in both the new directory structure as well as the old.

I don't think I see any risk for resolving the presence of a setup.py to determine which code path a directory exists on, but I could also be missing something.

I know //build is ongoing, but when you get a free moment could you take a look at this?

@scbedd
Updating management-plane generation scripts to handle packages in th…
15a40f6 
…e new directory structure. Removing pyproj and sln
@scbedd scbedd force-pushed the repo-restructure-scripts branch from 54c4299 to 15a40f6 Compare May 8, 2019 18:51
@lmazuel lmazuel merged commit df00f61 into Azure:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scbedd @adxsdk6 @codecov-io @lmazuel