Adding Impression Pixel #4479
Merged
Adding Impression Pixel #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
annatisch,
areddish,
DheerendraRathor,
djyou,
hvermis,
idear1203,
jaredmoo,
kalyanaj and
matthchr
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
scbedd
requested review from
mboersma,
ro-joowan,
samedder,
samkreter,
schaabs,
shutchings,
tjprescott,
vchske,
xizha162 and
yugangw-msft
as code owners
scbedd
removed request for
mboersma,
jaredmoo,
djyou,
DheerendraRathor,
samkreter,
tjprescott and
yugangw-msft
Codecov Report
@@ Coverage Diff @@
## master #4479 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 10458 10458
Lines 219467 219467
=======================================
Hits 117155 117155
Misses 102312 102312Continue to review full report at Codecov.
|
lmazuel
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peter and co want to be able to see distribution of viewership in the context of all this Track 2 work we're doing.
Adding an impression pixel is the only way currently that github can't curtail.
@Azure/azure-sdk-eng