Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Servicebus] Review feedback #4201

Merged
merged 9 commits into from
Jan 17, 2019
Merged

[Servicebus] Review feedback #4201

merged 9 commits into from
Jan 17, 2019

Conversation

annatisch
Copy link
Member

No description provided.

@annatisch annatisch requested a review from lmazuel as a code owner January 17, 2019 15:52
@adxsdk6
Copy link

adxsdk6 commented Jan 17, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented Jan 17, 2019

Can one of the admins verify this patch?

@annatisch annatisch removed the request for review from lmazuel January 17, 2019 15:57
@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #4201 into servicebus will increase coverage by 0.07%.
The diff coverage is 56.52%.

Impacted file tree graph

@@              Coverage Diff               @@
##           servicebus    #4201      +/-   ##
==============================================
+ Coverage       53.69%   53.77%   +0.07%     
==============================================
  Files            9854     9854              
  Lines          209436   209782     +346     
==============================================
+ Hits           112464   112811     +347     
+ Misses          96972    96971       -1
Impacted Files Coverage Δ
...ervicebus/azure/servicebus/common/mgmt_handlers.py 15.51% <ø> (ø) ⬆️
...re-servicebus/azure/servicebus/aio/async_client.py 26.17% <ø> (+0.38%) ⬆️
...s/azure/servicebus/control_client/_common_error.py 88.23% <ø> (ø) ⬆️
...cebus/azure/servicebus/control_client/constants.py 100% <ø> (ø) ⬆️
...rvicebus/azure/servicebus/control_client/models.py 94.8% <ø> (+0.06%) ⬆️
.../azure/servicebus/control_client/_common_models.py 68.42% <ø> (ø) ⬆️
azure-servicebus/azure/servicebus/common/errors.py 39.7% <ø> (ø) ⬆️
...re/servicebus/control_client/_common_conversion.py 65.38% <ø> (ø) ⬆️
...re-servicebus/azure/servicebus/common/constants.py 100% <ø> (ø) ⬆️
azure-servicebus/azure/servicebus/common/utils.py 25% <ø> (ø) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda31ea...adf6032. Read the comment docs.

@annatisch annatisch merged this pull request into Azure:servicebus Jan 17, 2019
annatisch added a commit that referenced this pull request Jan 17, 2019
* Review feedback

* Moved pylint config

* Test stabilization

* Updated readme

* SB capitalization

* Docstring fixes

* Block comments

* Flake8 docs pass

* Pylint fix
lmazuel pushed a commit that referenced this pull request Jan 18, 2019
*  New ServiceBus SDK (#4137)

* Servicebus docs updates (#4180)

* Docs updates

* Some docs cleanup

* More docs fixes

* Fixed docs indentation

* More docs updates

* Added Example tags

* More docstrings

* Fixed return type

* Update CODEOWNERS

* Test fixes

* Review feedback (#4201)

* Review feedback

* Moved pylint config

* Test stabilization

* Updated readme

* SB capitalization

* Docstring fixes

* Block comments

* Flake8 docs pass

* Pylint fix

* Updated readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants