Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch - Update to latest REST API #4172

Merged
merged 8 commits into from
Jan 23, 2019
Merged

Batch - Update to latest REST API #4172

merged 8 commits into from
Jan 23, 2019

Conversation

bgklein
Copy link
Contributor

@bgklein bgklein commented Jan 13, 2019

No description provided.

@bgklein
Copy link
Contributor Author

bgklein commented Jan 13, 2019

@xingwu1 for review

@adxsdk6
Copy link

adxsdk6 commented Jan 13, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented Jan 13, 2019

Can one of the admins verify this patch?

@bgklein
Copy link
Contributor Author

bgklein commented Jan 15, 2019

@lmazuel @annatisch any idea why the CI is failing? Seems to be complaining about setup.py which is unchanged

@lmazuel
Copy link
Member

lmazuel commented Jan 15, 2019 •
edited
Loading

@bgklein

The project's long_description has invalid markup which will not be rendered on PyPI. The following syntax errors were detected:
line 64: Error: Unexpected indentation.

This means the HISTORY is not valid RST

lmazuel
lmazuel approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a tiny update on packaging, otherwise LGTM, just le me know when it's ready to merge and release.

@lmazuel
Copy link
Member

lmazuel commented Jan 15, 2019

@xingwu1 @bgklein @matthchr You might want to apply the same "models" update than azure-batch, since it's breaking release. At your convenience.

@bgklein
Copy link
Contributor Author

bgklein commented Jan 16, 2019

Good thought! I have ran the script so now both should be aligned. Good to merge whenever you have time

@bgklein
Copy link
Contributor Author

bgklein commented Jan 16, 2019

Going to update one of the method comments real quick

@bgklein
Copy link
Contributor Author

bgklein commented Jan 16, 2019

Good for merge

@bgklein
Copy link
Contributor Author

bgklein commented Jan 17, 2019

@lmazuel

@bgklein
Copy link
Contributor Author

bgklein commented Jan 18, 2019

@annatisch do you have merge/publish permissions? Waiting on this to be published to update CLI components. Thanks.

@bgklein
Copy link
Contributor Author

bgklein commented Jan 22, 2019

@lmazuel could we get this merged?

@lmazuel
Copy link
Member

lmazuel commented Jan 23, 2019

Sorry @bgklein holiday + training, got far far away from a keyboard for a few days :/
Merge and release now, thanks for your patience

@lmazuel lmazuel merged commit 0b930d6 into Azure:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@matthchr matthchr Awaiting requested review from matthchr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgklein @adxsdk6 @lmazuel