New ServiceBus SDK #4165
New ServiceBus SDK #4165
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #4165 +/- ##
==========================================
- Coverage 54.04% 53.77% -0.27%
==========================================
Files 9838 9853 +15
Lines 207611 209786 +2175
==========================================
+ Hits 112194 112815 +621
- Misses 95417 96971 +1554
Continue to review full report at Codecov.
|
| import functools | ||
|
|
||
| from azure.servicebus.common import message | ||
| from azure.servicebus.common.utils import get_running_loop |
There was a problem hiding this comment.
Note for myself and FYI to you: I shall create a azure.common.async_tools with it instead of keeping this SB only
azure-servicebus/pylintrc
Outdated
| @@ -0,0 +1,45 @@ | |||
| [MASTER] | |||
There was a problem hiding this comment.
Is this the CLI one, or a SB specific one?
There was a problem hiding this comment.
It is the CLI one with one extra suppression: useless-object-inheritance
azure-servicebus/README.rst
Outdated
| @@ -1,222 +1,85 @@ | |||
| Microsoft Azure SDK for Python | |||
| ============================== | |||
|
|
|||
| This is the Microsoft Azure Service Bus Runtime Client Library. | |||
| This is the Microsoft Azure ServiceBus Client Library. | |||
There was a problem hiding this comment.
Recommend converting this README to Markdown, and reusing the content from the Service Bus landing page you've got in the other PR. Using the same content for the README, SDK landing page on docs, and the PyPi distribution page is the guidance we'll be putting forth, and is what we've standardized on based on the findings from the Python SDK UX studies.
See guidance here: Document your Azure SDK.
There was a problem hiding this comment.
I've updated the readme to be closer to the docs.ms.com overview - keeping as rst for first release as discussed offline, with subsequent move to markdown.
* Docs updates * Some docs cleanup * More docs fixes * Fixed docs indentation * More docs updates * Added Example tags * More docstrings * Fixed return type * Update CODEOWNERS * Test fixes
* Review feedback * Moved pylint config * Test stabilization * Updated readme * SB capitalization * Docstring fixes * Block comments * Flake8 docs pass * Pylint fix
No description provided.