Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CONTRIBUTING.md #31728

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Fix typo in CONTRIBUTING.md #31728

merged 2 commits into from
Aug 22, 2023

Conversation

FacerAin
Copy link
Contributor

@FacerAin FacerAin commented Aug 20, 2023

Description

Fix small typo in CONTRIBUTING.md
pip install tox<5 -> pip install 'tox<5'
Without quotes, the shell recognizes the < as stdout stream operator.
So, I added quotation marks and made the correction.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 20, 2023
@github-actions
Copy link

Thank you for your contribution @FacerAin! We will review the pull request and get back to you soon.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@FacerAin FacerAin requested a review from kristapratico August 22, 2023 14:08
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again 😃

@kristapratico
Copy link
Member

/check-enforcer override

@kristapratico kristapratico merged commit 08dd8a4 into Azure:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants