Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd Party Libs in Samples #29160

Merged
merged 1 commit into from
Mar 16, 2023
Merged

3rd Party Libs in Samples #29160

merged 1 commit into from
Mar 16, 2023

Conversation

ronniegeraghty
Copy link
Member

Adding guidance on the proper usage of 3rd Party Libraries in our samples.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Adding guidance on the proper usage of 3rd Party Libraries in our samples.
Copy link
Member

@rohit-ganguly rohit-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this change is going across all language contributing guidelines

@ronniegeraghty ronniegeraghty merged commit d9f3b01 into main Mar 16, 2023
@ronniegeraghty ronniegeraghty deleted the ronniegeraghty-patch-1 branch March 16, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants