Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[communication-identity] Export some missing *Properties types in the API #25758

Merged
merged 3 commits into from
Aug 23, 2022
Merged

[communication-identity] Export some missing *Properties types in the API #25758

merged 3 commits into from
Aug 23, 2022

Conversation

prprabhu-ms
Copy link
Contributor

Description

Export some missing types from the API. These types were referenced but not exported in the API.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Aug 18, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 18, 2022 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-identity
azure-communication-chat

@AikoBB AikoBB requested a review from petrsvihlik August 19, 2022 07:16
@AikoBB AikoBB merged commit b64b46a into Azure:main Aug 23, 2022
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
@prprabhu-ms @AikoBB @mccoyp
[communication-identity] Export some missing *Properties types in t…
600d9c4 
…he API (Azure#25758)

* Export missing property types

* identifier_from_raw_id is exposed from chat modality

* updated chat changelog

Co-authored-by: Aigerim <aykobb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AikoBB AikoBB AikoBB left review comments

@petrsvihlik petrsvihlik petrsvihlik approved these changes

@annatisch annatisch annatisch approved these changes

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prprabhu-ms @azure-sdk @annatisch @petrsvihlik @AikoBB