Update tox so all ci steps can use local source if package reference not yet released #23897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jalauzon-msft I realized that with this change, we may have the risk of releasing a package with a dependency that doesn't yet exist on PyPI. Giving some thought to how I want to prevent that, and will update this PR with additional commits. Thanks for backporting! |
…t doesn't have at least one matching package on pypi for each requirement. Pin release versioning. Document additional skip in eng_sys_checks. Add typing on a few functions that are used by this PR
|
I decided
|
scbedd
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @scbedd making these changes in a Storage feature branch to unblock our ci. Just bringing them to
mainto separate out from Storage feature branch.These changes allow all ci steps to pull a package from local source if it's not yet released (and therefore not available via pip). The was needed for Storage since we have one package which directly depends on another, and we often need to update them together.