-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Key Vault] Fix test proxy tests in live pipelines #23786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
This issue points to a problem in the data-plane of the library.
labels
Apr 1, 2022
/azp run python - keyvault - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
kashifkhan
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Jun 25, 2023
Release microsoft.api management 2023 03 01 preview (Azure#23792) * Adds base for updating Microsoft.ApiManagement from version preview/2022-09-01-preview to version 2023-03-01-preview * Updates readme * Updates API version in new specs and examples * feat(apim): Provide capability to use custom hostname for Configuration API v2 (Azure#23785) Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * feat(rp): Added flags to enable/disable portals (Azure#23799) * feat(rp): Added flags to enable/disable portals * update default * feat(apim): Provide capability to disable legacy configuration API (Azure#23786) * feat(apim): Provide capability to disable legacy configuration API Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Update sample Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Fix type definition Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Switch to enum Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * Update samples Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> --------- Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> * feat(apim): Add new tracing API (Azure#23800) * Add new tracing api * Remove TODOs descriptions * Improve descriptions * Fix dot * Add missing examples * prettier fixes * Fix model and semantic problems * Remove get prefix in post operations * Use list prefix * Fix PR comments * feat(apim): Add ability to create and update new OData api (Azure#23849) * Add odata api definitions * add api usage example * fix file reference * address comments --------- Co-authored-by: rkolesnikov <rkolesnikov@microsoft.com> * migration contract (Azure#23983) * 2023 03 cred scan fix - Examples Only (Azure#24357) * remove-sas-signature * update example * 2023-03-01-preview arm review feedback (Azure#24404) * move to v5 subscription contract * move to v5 for rg and api-version * cred scan * default is true * uuid in examples * change from boolean to enums * fix default value --------- Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Harun Reşit <harun5hy@outlook.com> Co-authored-by: Rafał Mielowski <rmielowski@microsoft.com> Co-authored-by: Roman Kolesnikov <Rem.Kolomna@gmail.com> Co-authored-by: rkolesnikov <rkolesnikov@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
azure-keyvault-secrets
was migrated to use the test proxy yesterday, but we forgot to setAZURE_SKIP_LIVE_RECORDING
to True so that proxy behaviors would be bypassed in live test pipelines.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines