Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Fix create_if_not_exists() docstrings and tests #23751

Merged

Conversation

vincenttran-msft
Copy link
Member

This PR aims to address the following that was introduced in a previous PR #23574.

  1. View API unable to generate some paramtypes properly
  2. Change naming of create_if_not_exists() method to create_<lib_object>_if_not_exists() to increase clarity

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Mar 30, 2022
@vincenttran-msft vincenttran-msft enabled auto-merge (squash) March 30, 2022 23:26
Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for getting this done so quickly :)

@vincenttran-msft vincenttran-msft merged commit e6cdd05 into Azure:main Mar 31, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@vincenttran-msft vincenttran-msft deleted the vincenttran/create_if_v2 branch April 27, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants