[Storage] Added max_messages kwarg to receive_messages() #23654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
requested review from
amishra-dev,
zezha-msft,
annatisch,
tasherif-msft and
jalauzon-msft
as code owners
ghost
added
the
annatisch
reviewed
Mar 28, 2022
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/aio/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/aio/_queue_client_async.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/samples/queue_samples_message_async.py
Outdated
Show resolved
Hide resolved
vincenttran-msft
changed the title
annatisch
reviewed
Mar 29, 2022
jalauzon-msft
approved these changes
Mar 30, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised by a customer in #17301, their concern is that there is currently no support for defining a maximum number of messages to receive (and thus could be open to infinite loops under a set of certain circumstances).
This PR adds
max_messageskeyword support forreceive_messages()and also adds sample code showcasing its use-case inqueue_samples_message.py(and async-equivalents).Thanks to @tasherif-msft for laying the groundwork in #18783 for this PR!