[EventHubs] fix credential mypy #23548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhaoling
requested review from
annatisch,
swathipil and
rakshith91
as code owners
ghost
added
the
yunhaoling
force-pushed
the
yuling/eh/fix-mypy
branch
from
ae022db to
24b51ad
Compare
yunhaoling
force-pushed
the
yuling/eh/fix-mypy
branch
from
5d0d092 to
2b1eb24
Compare
yunhaoling
commented
Mar 18, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_client_base_async.py
Outdated
Show resolved
Hide resolved
yunhaoling
commented
Mar 21, 2022
yunhaoling
commented
Mar 21, 2022
swathipil
reviewed
Apr 1, 2022
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_client_base_async.py
Outdated
Show resolved
Hide resolved
|
API change check for API changes are not detected in this pull request for |
swathipil
approved these changes
Apr 1, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
* fix mypy * fix pylint * fix sync * Apply suggestions from code review * apply review feedback * move type checking to the front
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
* fix mypy * fix pylint * fix sync * Apply suggestions from code review * apply review feedback * move type checking to the front
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing issue: #21847