Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLU March Preview] Tests #23524

Merged
merged 35 commits into from
Mar 31, 2022
Merged

[CLU March Preview] Tests #23524

merged 35 commits into from
Mar 31, 2022

Conversation

mshaban-msft
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mshaban-msft mshaban-msft force-pushed the mshaban/clu_march_preview/tests branch from 5f13519 to a9252a8 Compare March 15, 2022 19:51
@mshaban-msft mshaban-msft marked this pull request as ready for review March 15, 2022 20:28
@mshaban-msft mshaban-msft requested a review from lmazuel as a code owner March 15, 2022 20:28
annatisch
annatisch reviewed Mar 22, 2022
View reviewed changes
...ognitivelanguage/azure-ai-language-conversations/azure/ai/language/conversations/_version.py Show resolved Hide resolved
...-conversations/azure/ai/language/conversations/models/_conversation_analysis_client_enums.py Show resolved Hide resolved
...-conversations/azure/ai/language/conversations/models/_conversation_analysis_client_enums.py Show resolved Hide resolved
...-conversations/azure/ai/language/conversations/models/_conversation_analysis_client_enums.py Show resolved Hide resolved
...cognitivelanguage/azure-ai-language-conversations/tests/async/test_conversation_app_async.py Show resolved Hide resolved
...guage/azure-ai-language-conversations/samples/async/sample_analyze_conversation_app_async.py Show resolved Hide resolved
...language-conversations/samples/async/sample_analyze_orchestration_app_conv_response_async.py Outdated Show resolved Hide resolved
...language-conversations/samples/async/sample_analyze_orchestration_app_luis_response_async.py Show resolved Hide resolved
...ge/azure-ai-language-conversations/tests/async/test_orchestration_app_luis_response_async.py Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-conversations/tests/test_orchestration_direct.py Show resolved Hide resolved
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@mshaban-msft mshaban-msft force-pushed the mshaban/clu_march_preview/tests branch from fb4a1f0 to cb897a8 Compare March 29, 2022 14:35
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-ai-language-conversations. You can review API changes here

@azure-sdk
Copy link
Collaborator

API change check for azure-ai-language-conversations

API changes have been detected in azure-ai-language-conversations. You can review API changes here

@annatisch annatisch merged commit 608ce6c into Azure:main Mar 31, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
@mshaban-msft @rakshith91
[CLU March Preview] Tests (Azure#23524)
3e59f45 
* add swagger.md

* generate client

* update swagger.md

* regenerate client

* samples - add conversation project sample

* tmp commit

* update conversations samples in both conversations and orchestration projects

* update samples

* update sync samples

* update samples - file names and secrets

* update samples readme

* add async samples

* update async samples

* update samples

* add some tests

* add qna test

* add async tests

* update tests

* update tests

* fix sync tests

* fixed async tests

* add recorded tests

* update changelog

* rename body to task

* update samples

* update conversation samples

* fix rebase

* re-record tests

* update samples to use input models

* update and re-record tests

* update swagger reference

* rename confidence score

* update samples

* updating samples for extra info

* update readme
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@mshaban-msft @rakshith91
[CLU March Preview] Tests (Azure#23524)
cf1a6ed 
* add swagger.md

* generate client

* update swagger.md

* regenerate client

* samples - add conversation project sample

* tmp commit

* update conversations samples in both conversations and orchestration projects

* update samples

* update sync samples

* update samples - file names and secrets

* update samples readme

* add async samples

* update async samples

* update samples

* add some tests

* add qna test

* add async tests

* update tests

* update tests

* fix sync tests

* fixed async tests

* add recorded tests

* update changelog

* rename body to task

* update samples

* update conversation samples

* fix rebase

* re-record tests

* update samples to use input models

* update and re-record tests

* update swagger reference

* rename confidence score

* update samples

* updating samples for extra info

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch annatisch approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshaban-msft @azure-sdk @annatisch