Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoPR] dns/resource-manager #2110

Merged
merged 7 commits into from
Mar 14, 2018
Merged

[AutoPR] dns/resource-manager #2110

merged 7 commits into from
Mar 14, 2018

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: dns/resource-manager

@AutorestCI AutorestCI requested a review from lmazuel as a code owner March 6, 2018 22:34
@AutorestCI AutorestCI mentioned this pull request Mar 6, 2018
Merged
10 tasks
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Mar 6, 2018 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-dns

You can install the package azure-mgmt-dns of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_dns/resource-manager#egg=azure-mgmt-dns&subdirectory=azure-mgmt-dns"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_dns/resource-manager#egg=azure-mgmt-dns&subdirectory=azure-mgmt-dns"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_dns/resource-manager
  • pip install -e ./azure-mgmt-dns

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_dns/resource-manager
  • pip wheel --no-deps ./azure-mgmt-dns

Direct download

Your files can be directly downloaded here:

@AutorestCI AutorestCI mentioned this pull request Mar 7, 2018
Merged
10 tasks
@lmazuel
Copy link
Member

lmazuel commented Mar 7, 2018

@AutorestCI rebase

@AutorestCI
[AutoPR dns/resource-manager] Add DNS 2017-10-01 API version (#2077)
38f8c84 
* Generated from 4709b831b9515ed6c45240d5a4421a63d0d7c1ea

Add DNS 2017-10-01 API version

* Generated from 95b6f270e9e4fb0221e5f8b8a92a788b457219d6

Add x-ms-client-name for recordsetnamesuffix for RecordSets_ListAllByDnsZone
@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@AutorestCI AutorestCI force-pushed the restapi_auto_dns/resource-manager branch from 4ba74c4 to 38f8c84 Compare March 7, 2018 18:05
@AutorestCI AutorestCI mentioned this pull request Mar 7, 2018
Merged
10 tasks
AutorestCI and others added 4 commits March 8, 2018 15:22
@AutorestCI
Generated from 15ee9924ab753d364d43aec746d3dbd76a5570a7 (#2121)
8ae0fc2 
Fix SDK breaking change in 2017-10-01 DNS Swagger and add linter error suppressions
@AutorestCI @lmazuel
[AutoPR dns/resource-manager] Adding changes to support Private DNS P…
8222b2e 
…ublic Preview (#2132)

* Generated from c7fd5f85b7c3e7389ff7cf4b533c1bed1aeead08

Update Py version

* Fixing public zone test. Adding private zone test.

* Separating creation of virtual networks in a preparer class.

* Generated from 376c664778e112a01c129a0fbeebdf0f7d8a5c1e

removing the required property on zoneType also fixing example
@lmazuel
DNS swagger as of 08eebca
befe22e
@lmazuel
Prepare azure-mgmt-dns 2.0.0rc1
9479fba
@codecov-io
Copy link

codecov-io commented Mar 14, 2018 •
edited
Loading

Codecov Report

Merging #2110 into master will decrease coverage by 3.23%.
The diff coverage is 62.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2110      +/-   ##
==========================================
- Coverage   53.08%   49.84%   -3.24%     
==========================================
  Files        4774     5571     +797     
  Lines      119517   145348   +25831     
==========================================
+ Hits        63440    72446    +9006     
- Misses      56077    72902   +16825
Impacted Files Coverage Δ
...re/mgmt/dns/models/record_set_update_parameters.py 66.66% <0%> (-13.34%) ⬇️
azure-mgmt-dns/azure/mgmt/dns/models/ptr_record.py 66.66% <0%> (-13.34%) ⬇️
...ure-mgmt-dns/azure/mgmt/dns/models/cname_record.py 66.66% <0%> (-13.34%) ⬇️
azure-mgmt-dns/azure/mgmt/dns/models/mx_record.py 57.14% <0%> (-9.53%) ⬇️
azure-mgmt-dns/azure/mgmt/dns/models/caa_record.py 50% <0%> (-7.15%) ⬇️
...zure-mgmt-dns/azure/mgmt/dns/models/aaaa_record.py 66.66% <0%> (-13.34%) ⬇️
azure-mgmt-dns/azure/mgmt/dns/models/srv_record.py 44.44% <0%> (-5.56%) ⬇️
azure-mgmt-dns/azure/mgmt/dns/models/txt_record.py 66.66% <0%> (-13.34%) ⬇️
azure-mgmt-dns/azure/mgmt/dns/version.py 100% <100%> (ø) ⬆️
...ure-mgmt-dns/azure/mgmt/dns/models/sub_resource.py 100% <100%> (ø)
... and 1007 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f262d80...efebd20. Read the comment docs.

@AutorestCI AutorestCI mentioned this pull request Mar 14, 2018
Merged
10 tasks
@lmazuel lmazuel merged commit 4746aba into master Mar 14, 2018
@lmazuel lmazuel deleted the restapi_auto_dns/resource-manager branch March 14, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
ServicePR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AutorestCI @lmazuel @codecov-io