Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-core, add new AzureCloud expandable enum #43099

Merged
merged 12 commits into from
Jan 10, 2025

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Nov 26, 2024

Description

Add AzureCloud enum to azure-core and adopt it in azure-core-management.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Azure.Core azure-core label Nov 26, 2024
@XiaofeiCao XiaofeiCao changed the title azure cloud azure-core, add new AzureCloud expandable enum Nov 26, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 27, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-core-management
com.azure:azure-core

@XiaofeiCao XiaofeiCao closed this Jan 2, 2025
@XiaofeiCao XiaofeiCao reopened this Jan 2, 2025
@XiaofeiCao XiaofeiCao merged commit dbd675b into Azure:main Jan 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants