Cleanup docs #159
Merged
Cleanup docs #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
requested review from
chlafreniere and
lucyzhang929
as code owners
README.md
Outdated
| ### Input Binding Tutorial | ||
|
|
||
| Note: This tutorial requires that the Azure SQL database is setup as shown in [Create Azure SQL Database](#Create-Azure-SQL-Database). | ||
| Note: This tutorial requires that the SQL database is setup as shown in [Create Azure SQL Database](#Create-a-SQL-Server). |
There was a problem hiding this comment.
Should this be [Create a SQL Database]?
There was a problem hiding this comment.
Do we also want to update the note in Output Binding Tutorial (line 213)?
lucyzhang929
approved these changes
Nov 11, 2021
README.md
Outdated
| ### Input Binding Tutorial | ||
|
|
||
| Note: This tutorial requires that the Azure SQL database is setup as shown in [Create Azure SQL Database](#Create-Azure-SQL-Database). | ||
| Note: This tutorial requires that the SQL database is setup as shown in [Create Azure SQL Database](#Create-a-SQL-Server). |
There was a problem hiding this comment.
Do we also want to update the note in Output Binding Tutorial (line 213)?
|
@dzsquared Merging this in now so people can get the updates, if you get a chance to look it over just leave any comments here and I'll fix them up later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-organizing and clarifying some parts. Also moved away from having Azure SQL be the only choice to reduce friction for new devs so they can get started ASAP using something like docker.
Lots more work to do I'm sure but this at least fixes the majority of the things that I had noted could use with some polishing 😄
Link to the README so you can check out what it actually looks like https://github.com/Azure/azure-functions-sql-extension/blob/chgagnon/cleanupDocs/README.md