Improving Retry Test for Webjobs Version Upgrade #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainharsh98
changed the title
This reverts commit 05fbe3f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently the End-to-End test for Retry checks if an exception is logged from the kafka function exactly Number of Retries + 1 times. Since the last upgrade, WebJobs SDK has added an additional log after all retires are exhausted to capture the last error throw. This would mean that the actual number of times the exception is logged would increase by 1 for the above test scenario - Leading to the failure of the test in case of WebJobs SDK upgrade. PR link - Azure/azure-webjobs-sdk#2914
Solution:
To remove the dependency on the number of times the exception is logged - This PR introduces a change to look at the actual number of executions of the function from the logs. This is done to unblock the future WebJobs SDK upgrade scenarios.