[AppService] az functionapp delete: Add a validation to check whether Azure Functions is not in the Azure Container app environments
#25979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
ghost
added
the
ghost
requested review from
kaibocai
changed the title
az functionapp create: Support container app deployments
|
/azp run |
|
Commenter does not have sufficient privileges for PR 25979 in repo Azure/azure-cli |
Block update and config container delete commands for Centauri
…zure-cli into kaibocai/quick-fix
|
AppService |
zhoxing-ms
approved these changes
Mar 30, 2023
zhoxing-ms
changed the title
az functionapp create: Support container app deploymentsaz functionapp delete: Add a validation to check whether Azure Functions is not in the Azure Container app environments
zhoxing-ms
approved these changes
Mar 30, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…er Azure Functions is not in the Azure Container app environments (Azure#25979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp create
Description
As part of the Centauri effort, we need to add the --environment parameter to the az functionapp create command so that customers can pass the managed AKS environment where the function app will be deployed.
We will not consume the --plan and --consumption-plan-location parameters since plans are not relevant for function apps deployed in managed environments. This is why server_farm_id is not set for Centauri.
We will also not consume the --os-type since it will need to be Linux.
The location is set to be the container app environment location.
Testing Guide
Create an App Service plan (az functionapp plan create -g -n --sku S1)
Create an managed AKS environment(az containerapp env create -n -g )
Create a function app in the managed AKS environment (az functionapp create -g -n --plan -s --environment )
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.