-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Core} Support preview extension to override GA extension #25802
Merged
wangzelin007
merged 5 commits into
Azure:dev
from
wangzelin007:extension_overwrite_20230314
Mar 29, 2023
Merged
{Core} Support preview extension to override GA extension #25802
wangzelin007
merged 5 commits into
Azure:dev
from
wangzelin007:extension_overwrite_20230314
Mar 29, 2023
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
Core |
6eac3e9
to
ebe6245
Compare
Juliehzl
previously approved these changes
Mar 16, 2023
jsntcy
reviewed
Mar 29, 2023
jsntcy
approved these changes
Mar 29, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
* Update __init__.py * Create overwrite_order_in_cli.md * Update overwrite_order_in_cli.md * Update __init__.py * Update __init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions for use
You need to ensure that the extension name of preview is sorted after the extension name of GA
For example:
GA extension name: containerapp
Preview extension name: containerapp-preview
Testing result
Description
Now, our command table is loaded three times
Load the modules first and then the extensions
Load wheel extensions then dev extensions
Load wheel extensions
Load dev extensions
The extensions in each level are loaded in order determined by the order of os.listdir results.
![image](https://user-images.githubusercontent.com/18628534/224947749-0a6fe24a-7610-404a-b2b5-9458f5712175.png)
![image](https://user-images.githubusercontent.com/18628534/224947494-d04921fd-f573-44f2-bf8b-5a14ee91337d.png)
But os.listdir is in arbitrary order, if the name contains numbers, the order will be messed up.
For example:
listdir with name does not contain number
listdir with name contain number
So add a sort to ensure alphabetical order.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.