This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Code architecture refactoring and fixing project structure #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkerkhove
suggested changes
Feb 14, 2022
...APIM_ARMTemplate/apimtemplate/Common/Exceptions/NoApiVersionSetWithSuchNameFoundException.cs
Outdated
Show resolved
Hide resolved
...Template/apimtemplate/Common/Exceptions/SingleAndMultipleApisCanNotExistTogetherException.cs
Outdated
Show resolved
Hide resolved
src/APIM_ARMTemplate/apimtemplate/Common/Helpers/CollectionHelpers.cs
Outdated
Show resolved
Hide resolved
src/APIM_ARMTemplate/apimtemplate/Common/Helpers/CollectionHelpers.cs
Outdated
Show resolved
Hide resolved
src/APIM_ARMTemplate/apimtemplate/Commands/Applications/ExtractApplication.cs
Outdated
Show resolved
Hide resolved
src/APIM_ARMTemplate/apimtemplate/Commands/Applications/CreateApplication.cs
Outdated
Show resolved
Hide resolved
DeagleGross
changed the title
DeagleGross
changed the title
DeagleGross
commented
Feb 15, 2022
Hardell
approved these changes
Feb 15, 2022
tomkerkhove
approved these changes
Feb 15, 2022
DeagleGross
added a commit
that referenced
this pull request
Feb 18, 2022
)" This reverts commit 1f8e00e.
Hardell
pushed a commit
that referenced
this pull request
Mar 18, 2022
Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com>
DeagleGross
added a commit
that referenced
this pull request
Mar 21, 2022
* Code architecture refactoring and fixing project structure (#612) Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * Added .editorconfig and fixed style according to it (#621) * added .editorconfig and fixed style according to it * add issue link to TODO for creator executor Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * PolicyExtractor refactoring & testing (#625) * Initial extractorExecutor parameters\configuration refactoring + tests setup * codestyle fixes. created apiclients and separated API + extraction for policy extractor * review updates * explicit variable for fixing dotnet build error CS0815 * fix IO.DirectoryNotFoundException in tests * rename `ToParameterize` properties * move template creator to Common\Templates\Abstractions * rename templateCreator to templateGeneratorBase and make it a parent for all creators\extractors Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * add DI to application (#631) * add DI to application * cleared entry pointed, deleted reflection, get rid of comman-line library dependencies in business logic code * review +build fix Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * product-apis extractor refactoring (#636) * product apis refactoring * launchsettings.json rollback * rename service api products extractor * global renaming, fix PR review * rename product-apis response and properties Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * order resources section fields of generated templates (#637) * order resources section fields of generated templates * fix comment Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * refactor product extractor, fix logging, rework api-clients (#639) * refactor product extractor, fix logging, rework api-clients * rename predefined parameter * parameter order fix * rollback launch settings. json * ignore changes in launch settings json * make template builder as an injectable service * exclude template builder extensions * removed explicit discard Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * fix typos in paths (#640) Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * implement groups extractor (#641) * implement groups extractor * [review] duplicated code removal, cleaning tests, fixing namings Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * ApiVersionSet, AuthorizationServer extractors refactoring (#643) Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * make templates generic & refactor api-extractor (#644) * make templates generic + refactor api-extractor * runtime bugs fixes * PR review Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * serialization fixes after refactoring + entry point descriptions added (#645) * serialization fixes * provide fully-described outputs and fulfill rdocumentation * fix required options for commands * fix spaces Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com> * fix refactoring breaking changes (checked manually) * remove public pipelines Co-authored-by: Dmitrii Korolev <dmkorolev@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I have done in this PR:
apimtemplatetoMicrosoft.Azure.Management.ApiManagement.ARMTemplates). Now all source code is insrc\ARMTemplates\project, all tests are intests\ARMTemplates.Testsproject. Fixed documentation with links to projects.tests\ARMTemplates.Tests\Resources, so that there is no dependency for the src. Fixed tests.Extractoroption of console application: now there is an ExtractorExecutor, that gets the ExecutorConfig instance (parameters for launch) + has all the extractors as interfaces. That change leads to possibility of testing Extractor correctly with Mocks.So plan of fixing this repo is in this state after merging the PR:
Relates to https://github.com/Azure/azure-api-management-devops-resource-kit/issues/607,
Relates to #616