Addressing fixes for GitHub issues 738, 753 and 745 #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm-ttk/testcases/deploymentTemplate/Parameter-Types-Should-Be-Consistent.test.ps1
Outdated
Show resolved
Hide resolved
raosuhas
reviewed
Nov 9, 2023
arm-ttk/testcases/deploymentTemplate/Parameter-Types-Should-Be-Consistent.test.ps1
Outdated
Show resolved
Hide resolved
raosuhas
reviewed
Nov 9, 2023
| Write-Error -ErrorId Inconsistent.Parameter -Message "Type Mismatch: Parameter '$parameterName' in nested template '$($inner.ParentObject[0].name)' is defined as $innerTemplateParameterType, but the parent template defines it as $($parent.parameters.$mappedParameterName.type))." -TargetObject ([PSCustomObject]@{ | ||
| JSONPath = $inner.JSONPath + ".parameters.$parameterName" | ||
| }) | ||
| JSONPath = $inner.JSONPath + ".parameters.$parameterName"}) |
There was a problem hiding this comment.
undo this part of the change
raosuhas
reviewed
Nov 17, 2023
| ) { | ||
| $innerTemplateParamValue = $innerTemplateParam.Value | ||
| $regexParam = ".*parameters(?<mappedParameterName>\(.*\))(\[.*?\]|\.|\,)(.*)\]" # https://regex101.com/r/V0dzVv/1 and https://regex101.com/r/ao6tsK/1 https://github.com/Azure/arm-ttk/issues/635 |
There was a problem hiding this comment.
i thinkyou need .*[ right ?
There was a problem hiding this comment.
it is [.*, will add it
added 3 commits
November 17, 2023 13:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix if an inner template parameter referenced a parent template parameter, if the value of the inner template parameter was not in the form [parameters('parenttemplateparam').....] or [parameters('parenttemplateparam')] then an error would be thrown. This PR fixes the regex where the error will not be thrown to include values like *parameter('parenttemplateparam')... or *parameter('parenttemplateparam'), or *parameter('parenttemplateparam')]
Also if the VALUE of an innertemplateparam is an object, then the correct value was not retrieved previously. This is also fixed.
Addressing issues:
#745
(Removed the condition to have '[' before parameters and a comma can be accepted besides '.' and ']')
Test file unit-tests/Parameter-Types-Should-Be-Consistent/Pass/bicepTemplate.json is related
#753
Test file unit-tests/Parameter-Types-Should-Be-Consistent/Pass/innerParamArrayBicepTemplate.json is a test for this issue
The code change where the inner template parameter value.value is retrieved and if the type is not a string then the error is not thrown.
#738
Test file unit-tests/Parameter-Types-Should-Be-Consistent/Pass/twoModuleBicepTemplate.json is a test for this issue
The regex fix to remove the requirement of the regex to always have its value to begin with '[parameters' is lifted.