minor fixes in e2e tests ext_cgroups, agent_update and agent_publish #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
narrieta
reviewed
Aug 29, 2024
| @@ -68,6 +71,22 @@ def get_ignore_errors_before_timestamp(self) -> datetime: | |||
| timestamp = self._ssh_client.run_command("agent_publish-get_agent_log_record_timestamp.py") | |||
| return datetime.strptime(timestamp.strip(), u'%Y-%m-%d %H:%M:%S.%f') | |||
|
|
|||
| def _wait_for_agent_to_complete_provisioning(self): | |||
There was a problem hiding this comment.
I'd consider moving this somewhere in testss/lib, since it looks like a useful function that other tests could use
| log.info("Waiting for agent to complete provisioning, will check again after a short delay") | ||
|
|
||
| else: | ||
| fail("Timeout while waiting for the Agent to complete provisioning") |
There was a problem hiding this comment.
I think this should be "raise Exception" rather than "fail".
Both of them raise an exception, but fail/assert/etc should be used when the verifications the test is doing completed, but were not True. Other exceptions would be used when the test was trying to setup something, or waiting for something before doing its verifications like in this case, etc, and some error prevented the test to perform its verifications.
maddieford
approved these changes
Aug 29, 2024
narrieta
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ext_cgrups: run_remote_test swallowing the assertion error, so test failed to validate if assertion failed due to cgroups disabled. So removed calling run_remote_test
agent_update: when rsm_request sent, whole pipeline can take some time to update the goal state with the requested version, so increasing the timeout on that check
agent_publish: Tests are running before agent is ready. Added check for wait for agent to complete provisioning
Issue #
PR information
Quality of Code and Contribution Guidelines