Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian - Byte to string conversion for systemd service creation #2574

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Debian - Byte to string conversion for systemd service creation #2574

merged 2 commits into from
Apr 29, 2022

Conversation

thedarksage
Copy link
Contributor

@thedarksage thedarksage commented Apr 28, 2022 •
edited
Loading

Description

Issue # (#2573)

Added string decode for byte to string conversion while checking for presence of systemd

return from subprocess.check_output(['cat', '/proc/1/comm']).strip() for python3 ===> b'systemd'
return from subprocess.check_output(['cat', '/proc/1/comm']).strip() for python2 ===> 'systemd'

#2573
-->

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #2574 (6342353) into develop (10c49a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2574   +/-   ##
========================================
  Coverage    71.92%   71.92%           
========================================
  Files          102      102           
  Lines        15392    15392           
  Branches      2445     2445           
========================================
  Hits         11071    11071           
  Misses        3826     3826           
  Partials       495      495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c49a1...6342353. Read the comment docs.

@thedarksage
Copy link
Contributor Author

return from subprocess.check_output(['cat', '/proc/1/comm']).strip() for python3 ===> b'systemd'
return from subprocess.check_output(['cat', '/proc/1/comm']).strip() for python2 ===> 'systemd'

#2573

@nagworld9
Copy link
Contributor

Since DCR pipeline is not working, I manually tested and looks good.

@nagworld9
Copy link
Contributor

@thedarksage Thanks for the fix.

@larohra
Copy link
Contributor

larohra commented Apr 29, 2022

Since DCR pipeline is not working, I manually tested and looks good.

@nagworld9 did you test this setup.py works for Debian images with py2 as default too?

@nagworld9
Copy link
Contributor

Since DCR pipeline is not working, I manually tested and looks good.

@nagworld9 did you test this setup.py works for Debian images with py2 as default too?

The Debian image that I tested had both py2 and py3. So, I ran setup.py with both pythons and it worked.
Additionally, we have decided to do DCR run to make sure of that.

@larohra larohra merged commit f0c0fb8 into Azure:develop Apr 29, 2022
@thedarksage thedarksage deleted the DebianSD branch June 8, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagworld9 nagworld9 nagworld9 approved these changes

@larohra larohra larohra approved these changes

@narrieta narrieta Awaiting requested review from narrieta narrieta is a code owner

@kevinclark19a kevinclark19a Awaiting requested review from kevinclark19a

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

@dhivyaganesan dhivyaganesan Awaiting requested review from dhivyaganesan

Assignees

@larohra larohra

@nagworld9 nagworld9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thedarksage @nagworld9 @larohra