Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of gen2 disks with udev rules #1954

Merged
merged 5 commits into from
Jul 20, 2020
Merged

Fix handling of gen2 disks with udev rules #1954

merged 5 commits into from
Jul 20, 2020

Conversation

trstringer
Copy link
Contributor

Description

Issue #1867

We do not currently handle gen2 disks properly with the current udev rule. With the implementation of this PR, we would have the following device symlinks:

$ tree /dev/disk/azure 
/dev/disk/azure 
├── azure_resource -> ../../sdb 
├── azure_resource-part1 -> ../../sdb1 
├── azure_root -> ../../sda 
├── azure_root-part1 -> ../../sda1 
├── azure_root-part14 -> ../../sda14 
├── azure_root-part15 -> ../../sda15 
└── scsi1 
    ├── lun0 -> ../../../sdc 
    └── lun1 -> ../../../sdd

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@trstringer trstringer mentioned this pull request Jul 20, 2020
Closed
@codecov
Copy link

codecov bot commented Jul 20, 2020 •
edited
Loading

Codecov Report

Merging #1954 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1954      +/-   ##
===========================================
- Coverage    69.66%   69.65%   -0.02%     
===========================================
  Files           85       85              
  Lines        11983    11925      -58     
  Branches      1676     1666      -10     
===========================================
- Hits          8348     8306      -42     
+ Misses        3263     3251      -12     
+ Partials       372      368       -4
Impacted Files Coverage Δ
azurelinuxagent/ga/monitor.py 77.32% <0.00%> (-0.65%) ⬇️
azurelinuxagent/common/event.py 85.93% <0.00%> (-0.18%) ⬇️
azurelinuxagent/common/utils/restutil.py 90.76% <0.00%> (ø)
azurelinuxagent/common/protocol/wire.py 77.00% <0.00%> (+0.43%) ⬆️
azurelinuxagent/common/utils/textutil.py 62.01% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d10203...a9787a7. Read the comment docs.

narrieta
narrieta previously approved these changes Jul 20, 2020
View reviewed changes
@pgombar pgombar merged commit d33f1f8 into Azure:develop Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgombar pgombar pgombar approved these changes

@narrieta narrieta narrieta approved these changes

@kevinclark19a kevinclark19a Awaiting requested review from kevinclark19a

@larohra larohra Awaiting requested review from larohra

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trstringer @narrieta @pgombar