Add functinality to skip checking/installing RDMA drivers on Network Dircect Infiniband VMs #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have OS.CheckRdmaDriver defined for waagent config, add a helper function to read its value. The default returned value is True if OS.CheckRdmaDriver is not defined in waagent.conf, this is for keeping the behavior of older versions of waagnet unchanged. On newer HPC images, checking and updating RDMA driver is not necessary. The user can elect to set OS.CheckRdmaDriver=n to skip those steps.
When "OS.CheckRdmaDriver=n", we don't need to check and install/update RDMA drivers.
If OS.CheckRdmaDriver is set to n, it's not neccesary to check driver version to decide if we should use the older method of provisioning Infiniband device. Use the new method of provisioning on the ethernet interface instead.
Add OS.CheckRdmaDriver and set it default value to Y. This parameter allows the user to choose to skip checking RDMA driver on newer HPC images. To skip checking and installing/updating RDMA driver, uncomment this parameter and set it to N.
|
Hi @longlimsft, Are there any plans to have regression tests? Thanks. |
|
This feature has been tested by us and by the customer. We are adding test cases to cover this. |
|
Thanks. I'll sign off once you let me know.
…On Thu, Jan 3, 2019 at 4:51 PM Long Li ***@***.***> wrote:
This feature has been tested by us and by the customer. We are adding test
cases to cover this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1385 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_6ADWqn8aGn0O7QVU7jEfyy9iOLSVYks5u_qWPgaJpZM4YFbld>
.
|
|
Please sign off now. There is no reason to wait as it doesn't affect any other code paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set adds the functionality to configure waagent to not check and install/update Network Direct RDMA drivers.
With the new HPC images, it's no longer mandatory to check/update drivers, the user can choose to skip those checks on system boot.
Issue #
PR information
Quality of Code and Contribution Guidelines