Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended removal logic to be more robust and in-depth #767

Merged
merged 81 commits into from
Dec 15, 2021
Merged

Extended removal logic to be more robust and in-depth #767

merged 81 commits into from
Dec 15, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Dec 8, 2021 •
edited
Loading

Change

  • Streamlined the removal script
  • Enabled the pipeline to resolve resources to remove in a recursive way via nested deployment names
  • Enabled pre- & post-removal scripts (e.g. to remove protected items from a RSV pre-removal / purge soft-deleted key vaults)

Pipeline reference:
AnalysisServices: Servers
NetApp: NetAppAccounts
Compute: VirtualMachines
Authorization: RoleAssignments
KeyVault: Vaults
Automation: AutomationAccounts
Network: VirtualWans
Authorization: PolicyAssignments
Authorization: PolicyDefinitions
Authorization: PolicyExemptions
CognitiveServices: Accounts
ApiManagement: Service

image

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

Unit Test Results

  1 files  ±0  1 suites  ±0   16s ⏱️ -1s
  9 tests +6  9 ✔️ +6    0 💤 ±0  0 ❌ ±0 
42 runs  +7  9 ✔️ +6  33 💤 +1  0 ❌ ±0 

Results for commit 1ab290f. ± Comparison against base commit c7eb52d.

This pull request removes 3 and adds 9 tests. Note that renamed tests count towards both. 
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/routeTables] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/routeTables] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/routeTables] used resource type [routeTables] should use on of the recent API version(s). Currently using [2021-02-01]

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints/privateDnsZoneGroups] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [vaults/accessPolicies] should use on of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [vaults/keys] should use on of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [vaults/secrets] should use on of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [vaults] should use on of the recent API version(s). Currently using [2019-09-01]

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr added [cat] pipelines category: pipelines [cat] testing category: testing enhancement New feature or request labels Dec 8, 2021
@AlexanderSehr AlexanderSehr marked this pull request as draft December 9, 2021 10:19
@AlexanderSehr AlexanderSehr marked this pull request as ready for review December 9, 2021 10:46
@AlexanderSehr AlexanderSehr marked this pull request as draft December 9, 2021 16:07
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 13, 2021 18:08
AlexanderSehr and others added 4 commits December 14, 2021 11:06
@AlexanderSehr
Updated removal task to use individual parameters instead of one hash…
0756a24 
…table object
@AlexanderSehr
Update to latest
adc8877
@eriqua
Update removal (#810)
4318ec4 
* parameter case level 01

* parameter case level 02 1

* parameter case level 02 2

* parameter case level 02 3

* parameter case level 03 1

* purge api

* res removal object

* body param to lower

* typo

* nw comment

* remove diagnostic

* invoke removal docs

* cleanup

* invoke removal docs example

* cleanup

Co-authored-by: Erika Gressi <erikag.microsoft.com>
@AlexanderSehr
Refactored removal object interfact
f5db96e
eriqua
eriqua approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 83dd4e8 into main Dec 15, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/removalImprovement branch December 22, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] pipelines category: pipelines [cat] testing category: testing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automation account removal - private endpoint Enhance removal logic incl. soft-delete
2 participants
@AlexanderSehr @eriqua