Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Update Eventhub Network Rules + latest APIs #1387

Merged
merged 8 commits into from
May 17, 2022
Merged

[Modules] Update Eventhub Network Rules + latest APIs #1387

merged 8 commits into from
May 17, 2022

Conversation

ahmadabdalla
Copy link
Contributor

Closes #1356

Description

  • Created the child resources for Network Rule Sets and replaced the existing 'network ACLs' property.
  • Updated module to use the latest APIs

Pipeline references

Pipeline
EventHub: Namespaces

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented May 13, 2022 •
edited
Loading

Unit Test Results

1 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c289af. ± Comparison against base commit a3fb1ab.

♻️ This comment has been updated with latest results.

@ahmadabdalla ahmadabdalla marked this pull request as ready for review May 13, 2022 03:34
@eriqua eriqua changed the title Update Eventhub Network Rules + latest APIs [Modules] Update Eventhub Network Rules + latest APIs May 13, 2022
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) May 13, 2022 08:22
@ahmadabdalla ahmadabdalla merged commit c99645c into main May 17, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/eventHubUpdates branch May 17, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua left review comments

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

networkAcl is not a valid property for EventHub Namespace
3 participants
@ahmadabdalla @AlexanderSehr @eriqua