-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StorageAccount: Cleanup + add publicNetworkAccess parameter #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…users/mast/SA_publicNetworkAccess
…users/mast/SA_publicNetworkAccess
AlexanderSehr
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Clean-up Storage Account properties/variables and add some missing properties
Problem statement:
The
requiredInfrastructureEncryption
looked good, but didn't work. We loose tool support when authoring (intellisense and linter) by having nested vars. It didn't show a warning when in a var, but bringing it in to the resource declaration and under property, it showed the issue.Adding:
publicNetworkAccess
enableInfrastructureEncryption
(was placed wrong and was not correctly configuring the setting before)Type of Change
Please delete options that are not relevant.
Checklist