-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing: Improve diff comparison when on custom branch #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ResourceModules into users/mast/publishDiffFix
MariusStorhaug
requested review from
AlexanderSehr,
ahmadabdalla,
rahalan and
eriqua
March 3, 2022 20:55
MariusStorhaug
changed the title
Users/mast/publish diff fix
Publishing: Improve diff comparison when on custom branch
Mar 3, 2022
…users/mast/publishDiffFix
ahmadabdalla
reviewed
Mar 3, 2022
ahmadabdalla
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Fix the publishing logic, so it works as expected in different scenarios. When doing prerelease in custom branch, it now compares whole content of the branch with the main/master branch to determine if a change has happened on a module. Old logic required a change to be on the last commit.
Behavior when running on custom branch with multiple commits where first commit was a change on version file for
shares
:GitHub:
https://github.com/MariusStorhaug/ResourceModules/runs/5413150374?check_suite_focus=true#step:4:243
ADO:
Behavior when merging after a PR:
GitHub:
https://github.com/MariusStorhaug/ResourceModules/runs/5413219475?check_suite_focus=true#step:4:243
ADO:
Type of Change
Please delete options that are not relevant.
Checklist