Show correct icons for new rendering skus #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
suggested changes
Jun 23, 2017
| @@ -14,10 +14,12 @@ const iconMapping = { | |||
| "SLES": Icons.openSUSE, | |||
| "SLES-HPC": Icons.openSUSE, | |||
| "standard-data-science-vm": Icons.windows, | |||
| "rendering-windows2016": Icons.windows, | |||
There was a problem hiding this comment.
I know this is not part of this pull request but I would move the rendering images to another tab so we have VMs, Data science Vms, and rendering vms
There was a problem hiding this comment.
Good point about that. I kind of missed the way these VM's were displayed and have only now seen the Data Science VM's tab. Makes perfect sense to have them in another tab. Will do that in this PR.
timotheeguerin
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #504